feat: handle native selection of tracks #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 2, 2017 00:23
OrenMe
suggested changes
Nov 4, 2017
| let audioTracks = this._getParsedAudioTracks(); | ||
| let textTracks = this._getParsedTextTracks(); | ||
| return videoTracks.concat(audioTracks).concat(textTracks); | ||
| _parseTracks(): void { |
There was a problem hiding this comment.
why not return tracks from here? we do the same in HLS and DASH adapters so why change convention?
added 2 commits
November 5, 2017 09:46
OrenMe
approved these changes
Nov 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
On iOS, when choosing from the native player (AVPlayer) audio track or text track, the player UI wasn't updated.
This PR bring sync between the player UI and the native UI.
CheckLists