Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-7380, FEC-7381): there are captions displayed when the captions are supposed to be 'off' #157

Merged
merged 2 commits into from
Nov 6, 2017
Merged

fix(FEC-7380, FEC-7381): there are captions displayed when the captions are supposed to be 'off' #157

merged 2 commits into from
Nov 6, 2017

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Nov 5, 2017

Description of the Changes

If the lang comparer receives an empty string as the input lang, it should always returns false (startsWith method will always return true for empty string...)

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv self-assigned this Nov 5, 2017
@OrenMe OrenMe merged commit 4b52b80 into master Nov 6, 2017
@OrenMe OrenMe deleted the FEC-7381 branch November 6, 2017 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@yairans yairans Awaiting requested review from yairans

Assignees

@dan-ziv dan-ziv

Labels
Priority: High Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dan-ziv @OrenMe