Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose playback rates api #165

Merged
merged 3 commits into from
Nov 26, 2017
Merged

feat: expose playback rates api #165

merged 3 commits into from
Nov 26, 2017

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Nov 26, 2017 •
edited
Loading

Description of the Changes

Expose api to get the possible player playback rates
player.playbackRates; // [0.5, 1, 2, 4]
Expose api to get the default playback rate
player.defaultPlaybackRate; // 1

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv requested a review from OrenMe November 26, 2017 08:32
@dan-ziv dan-ziv merged commit c6aa6c1 into master Nov 26, 2017
@dan-ziv dan-ziv deleted the expose-playbackRates-api branch November 26, 2017 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dan-ziv @OrenMe