Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: this._config.plugins.ima check fails if there are no plugins at all #173

Merged
merged 2 commits into from
Dec 21, 2017
Merged

fix: this._config.plugins.ima check fails if there are no plugins at all #173

merged 2 commits into from
Dec 21, 2017

Conversation

odedhutzler
Copy link
Contributor

@odedhutzler odedhutzler commented Dec 14, 2017 •
edited by OrenMe
Loading

Description of the Changes

In case the plugins property is undefined (when there are no plugins) the ima check fails, resulting in a load error (which retry resolves! : - ) )

Added protection

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@odedhutzler odedhutzler self-assigned this Dec 14, 2017
@OrenMe OrenMe merged commit c737649 into master Dec 21, 2017
@OrenMe OrenMe deleted the plugin_exists_check branch December 21, 2017 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@yairans yairans Awaiting requested review from yairans

@dan-ziv dan-ziv Awaiting requested review from dan-ziv

Assignees

@odedhutzler odedhutzler

Labels
Priority: High Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odedhutzler @OrenMe