Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: error printing #194

Merged
merged 3 commits into from
Feb 14, 2018
Merged

fix: error printing #194

merged 3 commits into from
Feb 14, 2018

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Feb 14, 2018

  • print error for any log level unless off
  • change the error message format

Description of the Changes

Please add a detailed description of the change, weather it's an enhancement or a bugfix.
If the PR is related to an open issue please link to it.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans
chore: error printing
7afc154 
* print error for any log level unless off
* change the error message format
@yairans yairans self-assigned this Feb 14, 2018
@yairans yairans requested a review from dan-ziv February 14, 2018 09:06
@yairans yairans changed the title chore: error printing docs: error printing Feb 14, 2018
@dan-ziv dan-ziv changed the title docs: error printing fix: error printing Feb 14, 2018
@dan-ziv dan-ziv merged commit b62cb6d into master Feb 14, 2018
@dan-ziv dan-ziv deleted the error-display branch February 14, 2018 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odedhutzler odedhutzler Awaiting requested review from odedhutzler

@dan-ziv dan-ziv Awaiting requested review from dan-ziv

Assignees

@yairans yairans

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yairans @dan-ziv