Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FEC-10290): upgrade NPM packages #446

Merged
merged 13 commits into from
Jul 20, 2020
Merged

feat(FEC-10290): upgrade NPM packages #446

merged 13 commits into from
Jul 20, 2020

Conversation

OrenMe
Copy link
Contributor

@OrenMe OrenMe commented Mar 8, 2020

Description of the Changes

Notable changes:

  1. update flow-bin to latest
  2. seperate class statics from instance and fix all occurances
  3. removed base-drm-protocol - in general static classes or classes that have no implementation or just have error throwing to alert the fact a class must adhere to an interface - we should just use an interface for that
  4. added Dom.js which adds missing or browser vendor specific Dom apis to types
  5. added base plugin interface methods for middleware, uicomponents

Need to:
Add engine decorator typings to plugin

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

OrenMe and others added 10 commits March 8, 2020 21:40
Notable changes:
1. update flow-bin to latest
2. seperate class statics from instance and fix all occurances
3. removed base-drm-protocol - in general static classes or classes that have no implementation or just have error throwing to alert the fact a class must adhere to an interface - we should just use an interface for that
3. added Dom.js which adds missing or browser vendor specific Dom apis to types
4. added base plugin interface methods for middleware, uicomponents

Need to:
Add engine decorator typings to pugin
@dan-ziv dan-ziv changed the title feat: update flow and flow definitions feat(FEC-10290): upgrade NPM packages Jul 20, 2020
@dan-ziv dan-ziv requested a review from a team July 20, 2020 11:32
@dan-ziv dan-ziv self-assigned this Jul 20, 2020
@dan-ziv dan-ziv merged commit 724715e into master Jul 20, 2020
@dan-ziv dan-ziv deleted the flowTypes branch July 20, 2020 15:11
OrenMe added a commit to kaltura/playkit-js-dash that referenced this pull request Jul 26, 2020
removed redundant base DRM class in favour of typed interface, as part of FEC-10290 changes in kaltura/playkit-js#446
borhandarabi pushed a commit to TasvirChi/playchi-js-dash that referenced this pull request May 14, 2024
removed redundant base DRM class in favour of typed interface, as part of FEC-10290 changes in kaltura/playkit-js#446
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants