-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(FEC-10290): upgrade NPM packages #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notable changes: 1. update flow-bin to latest 2. seperate class statics from instance and fix all occurances 3. removed base-drm-protocol - in general static classes or classes that have no implementation or just have error throwing to alert the fact a class must adhere to an interface - we should just use an interface for that 3. added Dom.js which adds missing or browser vendor specific Dom apis to types 4. added base plugin interface methods for middleware, uicomponents Need to: Add engine decorator typings to pugin
dan-ziv
changed the title
feat: update flow and flow definitions
feat(FEC-10290): upgrade NPM packages
Jul 20, 2020
dan-ziv
approved these changes
Jul 20, 2020
5 tasks
5 tasks
OrenMe
added a commit
to kaltura/playkit-js-dash
that referenced
this pull request
Jul 26, 2020
removed redundant base DRM class in favour of typed interface, as part of FEC-10290 changes in kaltura/playkit-js#446
borhandarabi
pushed a commit
to TasvirChi/playchi-js-dash
that referenced
this pull request
May 14, 2024
removed redundant base DRM class in favour of typed interface, as part of FEC-10290 changes in kaltura/playkit-js#446
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Notable changes:
Need to:
Add engine decorator typings to plugin
CheckLists