fix(FEC-10122): clear drop frame watcher and DRM selection #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
destroy dropped frames watcher on reset to avoid leak memory.
Yuvalke
changed the title
OrenMe
reviewed
May 27, 2020
| @@ -242,6 +243,10 @@ export default class Html5 extends FakeEventTarget implements IEngine { | |||
| this._mediaSourceAdapter.destroy(); | |||
| this._mediaSourceAdapter = null; | |||
| } | |||
| if (this._droppedFramesWatcher) { | |||
There was a problem hiding this comment.
any reason why you moved it down here? as it is dependent on _mediaSourceAdapter it could trow error if we destroy it after we destroy adapter
Same for reset above
There was a problem hiding this comment.
It doesn't matter but I changed it to keep the flow of code meaningful
OrenMe
previously approved these changes
May 27, 2020
OrenMe
approved these changes
May 27, 2020
Yuvalke
changed the title
Yuvalke
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
destroy dropped frames watcher on reset to avoid a memory leak.
clear the DRM selection for the use case of loading another media without DRM keeps selection.
CheckLists