Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-10512): handle memory leaks in smart TV #487

Merged
merged 2 commits into from
Sep 30, 2020
Merged

fix(FEC-10512): handle memory leaks in smart TV #487

merged 2 commits into from
Sep 30, 2020

Conversation

Yuvalke
Copy link
Contributor

@Yuvalke Yuvalke commented Sep 27, 2020 •
edited
Loading

Description of the Changes

issue: HTML5 event handler is too complex and took too long and the babel config causes memory issue on a smart TV.
Solution: simplify the handler and fix the babel plugin config which causes the memory issue.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@Yuvalke
fix: memory issue, handler for HTML5 too complex
1c6e0d9 
issue: HTML5 event handler is too complex and took too long.
Solution: simplify the handler and fix babel plugin which probably cause the leak.
@Yuvalke Yuvalke requested a review from a team September 27, 2020 09:25
@Yuvalke Yuvalke self-assigned this Sep 27, 2020
@Yuvalke Yuvalke changed the title fix: handler for HTML5 too complex could cause memory issue fix(FEC-10512): handler for HTML5 too complex could cause memory issue Sep 30, 2020
@Yuvalke Yuvalke changed the title fix(FEC-10512): handler for HTML5 too complex could cause memory issue fix(FEC-10512): handler for HTML5 event are too complex and babel cause memory issue on smart TV. Sep 30, 2020
@Yuvalke Yuvalke changed the title fix(FEC-10512): handler for HTML5 event are too complex and babel cause memory issue on smart TV. fix(FEC-10512): handler for HTML5 event are too complex and babel config cause memory issue on smart TV. Sep 30, 2020
@Yuvalke Yuvalke changed the title fix(FEC-10512): handler for HTML5 event are too complex and babel config cause memory issue on smart TV. fix(FEC-10512): smartTV memory leak due to babel config and HTML5 events handlers Sep 30, 2020
@Yuvalke Yuvalke changed the title fix(FEC-10512): smartTV memory leak due to babel config and HTML5 events handlers fix(FEC-10512): handle memory leaks in smart TV Sep 30, 2020
@Yuvalke Yuvalke merged commit 4e4a78f into master Sep 30, 2020
@Yuvalke Yuvalke deleted the perfomence-issue-smart-tv branch September 30, 2020 09:32
yairans pushed a commit that referenced this pull request Oct 18, 2020
@Yuvalke @yairans
fix(FEC-10512): handle memory leaks in smart TV (#487)
f1c29fc 
issue: HTML5 event handler is too complex and took too long and the babel config causes memory issue on a smart TV.
Solution: simplify the handler and fix the babel plugin config which causes the memory issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@dan-ziv dan-ziv dan-ziv approved these changes

Assignees

@Yuvalke Yuvalke

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yuvalke @OrenMe @dan-ziv