Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-10324): class instances merged like simple object #500

Merged
merged 2 commits into from
Nov 24, 2020
Merged

fix(FEC-10324): class instances merged like simple object #500

merged 2 commits into from
Nov 24, 2020

Conversation

Yuvalke
Copy link
Contributor

@Yuvalke Yuvalke commented Nov 2, 2020

Description of the Changes

Issue: config with instance object merged like object.
Solution: check if it's an instance of class and merge it.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@Yuvalke
fix(FEC-10324): class instances merged like simple object
6f539a5 
Issue: config with instance object merged like object.
Solution: check if it's instance of class and merge it.
@Yuvalke Yuvalke requested a review from a team November 2, 2020 11:13
@Yuvalke Yuvalke self-assigned this Nov 2, 2020
@OrenMe OrenMe requested a review from yairans November 23, 2020 15:12
@Yuvalke Yuvalke merged commit f06aa5e into master Nov 24, 2020
@Yuvalke Yuvalke deleted the FEC-10324 branch November 24, 2020 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@yairans yairans Awaiting requested review from yairans

Assignees

@Yuvalke Yuvalke

Labels
Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yuvalke @OrenMe