Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-10643): seek to live edge on first play redundant #502

Merged
merged 3 commits into from
Nov 24, 2020
Merged

Conversation

Yuvalke
Copy link
Contributor

@Yuvalke Yuvalke commented Nov 8, 2020

Description of the Changes

Issue: seek on low-level device could take a few seconds, remove it when it's not needed.
Solution: on the first play we're already on edge so it's redundant.

Solves FEC-10643

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

Issue: seek on low level device could take few seconds, remove it when it's not needed.
Solution: on first play we're already on edge so it's redundant.
@Yuvalke Yuvalke requested a review from a team November 8, 2020 10:22
@Yuvalke Yuvalke self-assigned this Nov 8, 2020
@Yuvalke Yuvalke merged commit 6583361 into master Nov 24, 2020
@Yuvalke Yuvalke deleted the FEC-10643 branch November 24, 2020 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants