fix: CEA708 subtitle doesn't get correct index on native #514
Conversation
| * @private | ||
| */ | ||
| _onTextTrackAdded(event: FakeEvent): void { | ||
| const videoElement = this.getVideoElement(); |
There was a problem hiding this comment.
we want to avoid accessing the native video element as much as possible, for example, this will fail for flash and youtube or any other external non HTML5 engine.
There was a problem hiding this comment.
@OrenMe why? get video element will be null and then nothing happens on the next check, otherwise, text tracks will be empty and if both are not empty for other engines it's ok that the logic will work
There was a problem hiding this comment.
Ok, but this logic was not needed till now for non - native text track, so what has changed?
We should strive to get away from this and not add more use cases.
There was a problem hiding this comment.
Flash and youtube won't raise this event anyway
There was a problem hiding this comment.
it's for native text track only, listener added only for useNativeTextTrack=true
Description of the Changes
Issue: addTrack on safari add the track to the first position on TextTrackList.
Solution: register after native tracks loaded to addtexttrack to make sure if new tracks adding on index 0 it'll change the indexes for all tracks otherwise it won't change it.
CheckLists