fix(FEC-10760): Youbora - bufferUnderrun event fired when buffering started and no bufferDuration in Ping events #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoyBregman
reviewed
Dec 7, 2020
| [Html5EventType.TIME_UPDATE]: () => { | ||
| if (this._player.currentTime !== this._lastWaitingTime && this._prevState && this._prevState.type === StateType.PLAYING) { | ||
| if ( | ||
| Env.browser.name === 'IE' && |
There was a problem hiding this comment.
So actually this is the only change in logic, right? the rest seems to be refactoring
There was a problem hiding this comment.
Yes...
Just changing the event dispatching to be from updateState because you always want to do it and there's no need to split it outside in so many places.
OrenMe
approved these changes
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
When buffering on live content, the order of events that triggered from the video element is:
playingwaitingtimeupdate(this is true for all browsers except IE)
Because we're triggering
playingontimeupdateevent we're causing Youbora to report end of buffer when the player is actually still buffering.The solution is to exclude this logic only to IE.
CheckLists