feat(FEC-10766): create text config section and option for styling #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: text track doesn't have a config for styling, there is only an API for styling. Solution: create a text container for the text track and add the options for styling the text track.
OrenMe
suggested changes
Dec 8, 2020
OrenMe
reviewed
Dec 8, 2020
OrenMe
suggested changes
Dec 27, 2020
keep the get/set for previous usage
OrenMe
reviewed
Dec 28, 2020
OrenMe
approved these changes
Dec 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Issue: text track doesn't have a config for styling, there is only an API for styling.
Solution: create a text container for the text track and add the options for styling the text track.
Add an option to disable external setting by set attribute explicit as null or ''.
fix test: should dispatch new state event - updateState dispatch the event so two events dispatched cause FEC-10760
CheckLists