Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-10766): create static method for copy instead inner config #524

Merged
merged 1 commit into from
Dec 30, 2020
Merged

fix(FEC-10766): create static method for copy instead inner config #524

merged 1 commit into from
Dec 30, 2020

Conversation

Yuvalke
Copy link
Contributor

@Yuvalke Yuvalke commented Dec 30, 2020

Description of the Changes

create new instance instead of changing the current instance and add helper to make a new object base config or make config base on current object.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@Yuvalke Yuvalke requested a review from a team December 30, 2020 12:32
@Yuvalke Yuvalke self-assigned this Dec 30, 2020
@Yuvalke Yuvalke merged commit ab06f5d into master Dec 30, 2020
@Yuvalke Yuvalke deleted the FEC-10766-1 branch December 30, 2020 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

Assignees

@Yuvalke Yuvalke

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yuvalke @OrenMe