Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-10878): order of text captions are broken on Safari browser #527

Merged
merged 1 commit into from
Jan 6, 2021
Merged

fix(FEC-10878): order of text captions are broken on Safari browser #527

merged 1 commit into from
Jan 6, 2021

Conversation

Yuvalke
Copy link
Contributor

@Yuvalke Yuvalke commented Jan 6, 2021

Description of the Changes

Issue: config used previous config
Solution: change the config to new config

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@Yuvalke
fix(FEC-10878): order of text captions are broken on Safari browser
aa1413f 
Issue: config used previous config
Solution: change the config to new config
@Yuvalke Yuvalke requested a review from a team January 6, 2021 12:47
@Yuvalke Yuvalke self-assigned this Jan 6, 2021
@Yuvalke Yuvalke merged commit 37bfb4f into master Jan 6, 2021
@Yuvalke Yuvalke deleted the FEC-10878 branch January 6, 2021 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RoyBregman RoyBregman RoyBregman approved these changes

Assignees

@Yuvalke Yuvalke

Labels
Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yuvalke @RoyBregman