Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FEC-10768): expose in-stream DASH thumbnails #543

Merged
merged 2 commits into from
Feb 23, 2021
Merged

feat(FEC-10768): expose in-stream DASH thumbnails #543

merged 2 commits into from
Feb 23, 2021

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Feb 16, 2021 •
edited
Loading

Description of the Changes

  • Add definition of ImageTrack.
  • Add definition of ThumbnailInfo.
  • Add new API getThumbnail(time) to player, engine and adapters interface.
  • Move all types to dedicated enums folder for better folder structure.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

yairans
yairans suggested changes Feb 16, 2021
View reviewed changes
src/thumbnail/thumbnail-info.js Outdated Show resolved Hide resolved
@dan-ziv dan-ziv merged commit 3b1d78e into master Feb 23, 2021
@dan-ziv dan-ziv deleted the FEC-10768 branch February 23, 2021 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yairans yairans yairans approved these changes

@OrenMe OrenMe Awaiting requested review from OrenMe

@Yuvalke Yuvalke Awaiting requested review from Yuvalke

@RoyBregman RoyBregman Awaiting requested review from RoyBregman

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dan-ziv @yairans