fix(FEC-11035): playback error dispatch from player instead of from engine #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yuvalke
changed the title
Yuvalke
changed the title
OrenMe
reviewed
Feb 28, 2021
| }) | ||
| .catch(error => { | ||
| this.dispatchEvent(new FakeEvent(Html5EventType.ERROR, error)); | ||
| .finally(() => { |
There was a problem hiding this comment.
not supported in IE11, please verify we transpile this.
https://caniuse.com/promise-finally
There was a problem hiding this comment.
It's OK, we're using it with post-roll on ads controller as well, tested it as well on IE11
yairans
suggested changes
Mar 11, 2021
yairans
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Issue: engine doesn't expose an error for playback error, it dispatched from the player instead - the engine decorator can't ignore the playback error.
Solution: change the dispatch from the player to the engine to make sure the playback error could reject on the engine decorator.
tests failed for scenario _nativeTextTracksMap has index 0 and 2(metadata between) so for raise an error when it gets to i = 1 that doesn't exist.
CheckLists