Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-11119): VR (360) media doesn't work on safari browser - no video displayed #557

Merged
merged 1 commit into from
Apr 4, 2021
Merged

fix(FEC-11119): VR (360) media doesn't work on safari browser - no video displayed #557

merged 1 commit into from
Apr 4, 2021

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Apr 4, 2021 •
edited
Loading

Description of the Changes

fix null pointer in the engine decorator (when target[prop] is null)

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans requested a review from a team April 4, 2021 13:08
@yairans yairans self-assigned this Apr 4, 2021
@OrenMe OrenMe changed the title fix(FEC-11119): VR (360) media doesn't works on safari browser - no video displayed - regression bug fix(FEC-11119): VR (360) media doesn't work on safari browser - no video displayed - regression bug Apr 4, 2021
@OrenMe OrenMe changed the title fix(FEC-11119): VR (360) media doesn't work on safari browser - no video displayed - regression bug fix(FEC-11119): VR (360) media doesn't work on safari browser - no video displayed Apr 4, 2021
@yairans yairans merged commit 4da0a2c into master Apr 4, 2021
@yairans yairans deleted the FEC-11119 branch April 4, 2021 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

Assignees

@yairans yairans

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yairans @OrenMe