Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-10381): sources config need to be passed via setSources api #567

Merged
merged 13 commits into from
May 23, 2021

Conversation

Yuvalke
Copy link
Contributor

@Yuvalke Yuvalke commented May 3, 2021

Description of the Changes

Issue: set sources config via configure.
Solution: set sources config via setSources config.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@Yuvalke Yuvalke changed the title fix(FEC-10381): sources config need to be passed via setMedia api fix(FEC-10381): sources config need to be passed via setSources api May 3, 2021
src/player.js Outdated Show resolved Hide resolved
src/player.js Show resolved Hide resolved
src/player.js Show resolved Hide resolved
yairans
yairans previously approved these changes May 20, 2021
@Yuvalke Yuvalke merged commit 4962b11 into master May 23, 2021
@Yuvalke Yuvalke deleted the FEC-10381 branch May 23, 2021 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants