Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FEC-11540): Cue-Point Manager #604

Merged
merged 3 commits into from
Sep 14, 2021
Merged

feat(FEC-11540): Cue-Point Manager #604

merged 3 commits into from
Sep 14, 2021

Conversation

semarche-kaltura
Copy link
Contributor

@semarche-kaltura semarche-kaltura commented Sep 13, 2021 •
edited by OrenMe
Loading

Description of the Changes

  • add addTextTrack API to player
  • add addTextTrack API to engine
  • update docs

Solves FEC-11540

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

yairans
yairans reviewed Sep 14, 2021
View reviewed changes
src/player.js Outdated Show resolved Hide resolved
@yairans
Copy link
Contributor

yairans commented Sep 14, 2021 •
edited
Loading

@semarche-kaltura please clone this ticket to FEC and change the label (actually I would change it to "CuePoint Manager" - "Push data to native tracks API" is tech detail)

@semarche-kaltura semarche-kaltura changed the title feat(FEV-1016): CuePoint Manager - Push data to native tracks API feat(FEC-11540): CuePoint Manager - Push data to native tracks API Sep 14, 2021
yairans
yairans previously approved these changes Sep 14, 2021
View reviewed changes
@semarche-kaltura semarche-kaltura changed the title feat(FEC-11540): CuePoint Manager - Push data to native tracks API feat(FEC-11540): Cue-Point Manager Sep 14, 2021
@semarche-kaltura semarche-kaltura merged commit 78b4538 into master Sep 14, 2021
@semarche-kaltura semarche-kaltura deleted the FEV-1016-expand-text-track-api branch September 14, 2021 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yairans yairans yairans approved these changes

@RoyBregman RoyBregman Awaiting requested review from RoyBregman

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@semarche-kaltura @yairans