fix(FEC-11537): Need to re-add fontScale to textStyle config for backward compatability #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yairans
reviewed
Sep 14, 2021
| @@ -148,6 +148,7 @@ class TextStyle { | |||
| let textStyle = new TextStyle(); | |||
| textStyle.fontEdge = getValue(setting.fontEdge, textStyle.fontEdge); | |||
| textStyle.fontSize = getValue(setting.fontSize, textStyle.fontSize); | |||
| textStyle.fontScale = getValue(setting.fontScale, textStyle.fontScale); | |||
There was a problem hiding this comment.
so if app overrides the fontSize only, the fontScale wiill override it and it won't be changed no?
same Q for cvaa changes
There was a problem hiding this comment.
In that case, getValue will receive settings.fontScale=undefined, and will fallback to textStyle.fontScale (which was set by fontSize)
There was a problem hiding this comment.
great. do we have unit tests for both fontSize and fontScale overrriding?
There was a problem hiding this comment.
Yes, see my changes to player.spec.js
yairans
approved these changes
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Re-add fontScale to textStyle for backward compatibility.
Fixes FEC-11537.
CheckLists