fix(FEC-11611): Pass the program ID when sending a bookmark #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yairans
reviewed
Nov 9, 2021
yairans
suggested changes
Nov 9, 2021
This was referenced Nov 9, 2021
Merged
added 3 commits
November 9, 2021 15:18
OrenMe
previously approved these changes
Nov 9, 2021
OrenMe
reviewed
Nov 9, 2021
yairans
previously approved these changes
Nov 9, 2021
yairans
approved these changes
Nov 9, 2021
5 tasks
JonathanTGold
added a commit
to kaltura/playkit-js-ott-analytics
that referenced
this pull request
Nov 9, 2021
### Description of the Changes pass the epgid metadata as program ID parameter when sending a bookmark pass the recordingId metadata as id parameter instead of entryId when sending a bookmark related pr: kaltura/playkit-js-providers#155 kaltura/playkit-js#615 kaltura/kaltura-player-js#504 kaltura/kaltura-player-js#503 Solves FEC-11611
JonathanTGold
added a commit
to kaltura/kaltura-player-js
that referenced
this pull request
Nov 9, 2021
### Description of the Changes Please add a detailed description of the change, whether it's an enhancement or a bugfix. If the PR is related to an open issue please link to it. related pr: kaltura/playkit-js-providers#155 kaltura/playkit-js-ott-analytics#64 kaltura/playkit-js#615 #503
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
add setSourcesMetadata api (to enable dynamically cofigure the epgId (programId) in the sources.metadata)
related pr:
kaltura/playkit-js-providers#155
kaltura/playkit-js-ott-analytics#64
kaltura/kaltura-player-js#504
kaltura/kaltura-player-js#503
CheckLists