fix(FEC-11745): Player_Web_Mac_Safari - Flash of live stream after Start Over #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yairans
suggested changes
Dec 21, 2021
yairans
approved these changes
Dec 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
issue: in live stream played on safari when you seek back to - 0 (start over), the currentTime jump to live edge (and equal to duration) for a few ms before resets back to 0, making the isOnLiveEdge() logic on the engine to evaluate to true
fix: move the isOnLiveEdge() api definition to the adapters level and let the native adapter to override the logic and return false by default as long as currentTime resetting was not completed
solves: FEC-11745
CheckLists