fix(FEC-11785): [Youbora] - update youbora options for drm system that is used by the player #624
Conversation
…m that is used by the player
Co-authored-by: Yair Ansbacher <[email protected]>
src/drm/fairplay.js
Outdated
| @@ -6,40 +6,41 @@ import {DrmScheme} from './drm-scheme'; | |||
| const _logger = getLogger('FairPlay'); | |||
|
|
|||
| const FairPlay: IDrmProtocol = class FairPlay { | |||
| static scheme: string = DrmScheme.FAIRPLAY; | |||
There was a problem hiding this comment.
so need to add it in others as well (playready, widevine)
but why do we need it at all?
There was a problem hiding this comment.
i need a way to fetch the selectd drm scheme in the native adatpter and the only indicatiaon is NativeAdapter._drmProtoco which seave she selected protocl
src/drm/fairplay.js
Outdated
| if (drmEntry) { | ||
| config.licenseUrl = drmEntry.licenseUrl; | ||
| config.certificate = drmEntry.certificate; | ||
| config.certificate = drmEntry.certificate || ''; |
There was a problem hiding this comment.
why is this being changed? are we sure empty string is valid?
There was a problem hiding this comment.
this is a type enforcement because the certificate filed on PKDrmDataObject type is optional
https://github.com/kaltura/playkit-js/blob/master/flow-typed/types/drm-data.js#L5
so we have to either fix like the above or remove the optional
| @@ -1226,4 +1226,12 @@ export default class NativeAdapter extends BaseMediaSourceAdapter { | |||
| return 0; | |||
| } | |||
| } | |||
|
|
|||
| getDrmInfo(): ?PKDrmDataObject { | |||
| if (NativeAdapter._drmProtocol && this._drmHandler) { | |||
There was a problem hiding this comment.
why the previous way was wrong? (_sourceObj.drmData)?
There was a problem hiding this comment.
_sourceObj.drmData is array of configured drm data objects , but is not indicating the actual active drm (like _drmProtocol dose)
…m that is used by the player (#175) expose the drm info releted pr: kaltura/kaltura-player-js#515 kaltura/playkit-js#624 kaltura/playkit-js-youbora#82 solves: FEC-11785
JonathanTGold
changed the title
…at is used by the player (#515) expose the drm info on the player releted pr: kaltura/playkit-js-youbora#82 kaltura/playkit-js-dash#175 kaltura/playkit-js#624 solves: FEC-11785
…at is used by the player (#82) update youbora options for drm system that is used by the player https://documentation.npaw.com/npaw-integration/docs/setting-options-and-metadata related prs: kaltura/kaltura-player-js#515 kaltura/playkit-js#624 kaltura/playkit-js-dash#175 solves: FEC-11785
…m that is used by the player (#175) expose the drm info releted pr: kaltura/kaltura-player-js#515 kaltura/playkit-js#624 kaltura/playkit-js-youbora#82 solves: FEC-11785
Description of the Changes
expose the drm info on the player, (and as a result - on the engine and on the adatpter levels)
related prs:
kaltura/kaltura-player-js#515
kaltura/playkit-js-dash#175
kaltura/playkit-js-youbora#82
solves: FEC-11785
CheckLists