Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-12350): external captions shown while cc button disabled #662

Merged
merged 4 commits into from
Sep 22, 2022

Conversation

lianbenjamin
Copy link
Contributor

@lianbenjamin lianbenjamin commented Sep 4, 2022

the issue:
when captions are external and disabling cc button, captions are still shown on player.

root cause:
player's API hideTextTrack() does not handle external captions.

Description of the Changes

  • check if active text track is external and use hideTextTrack() API of externalCaptionsHandler

Solves FEC-12350

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@giladna giladna merged commit 788d983 into master Sep 22, 2022
@giladna giladna deleted the FEC-12350-hide-external-captions-cc-disabled branch September 22, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants