Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-12351): cc button changed to enable during change media #663

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

Tzipi-kaltura
Copy link
Contributor

Description of the Changes

the issue:
when click on the cc button to disable caption and then occur the "change media" functionality the new video start with cc enabled.

root cause:
when turn off the caption from the cc button the previous language variable not change to off and still storing the previous language.

the solution:
the previous language viarable will be changed to off also when clicking cc button and not only when clicking "off" in the language button.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@Tzipi-kaltura Tzipi-kaltura merged commit b213ab7 into master Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants