Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ObjectTypeDefinition to InterfaceTypeDefinition creates error even if the fields are the same #1789

Open
Tracked by #2651 ...
gabsima-nexapp opened this issue Nov 12, 2020 · 0 comments
Labels
⚙️ work in progress Someone is working on it

Comments

@gabsima-nexapp
Copy link

gabsima-nexapp commented Nov 12, 2020

Describe the bug

An error occurs when generating diff between 2 schema when a response changes from an ObjectTypeDefinition to an InterfaceTypeDefinition even if both response contains the exact same fields. The graphql query we made before and after the change on this response worked as expected. This should not be an error.

To Reproduce
Steps to reproduce the behavior:

  1. Generate a schema with a graphql response containing an ObjectTypeDefinition
  2. Generate the same schema changing the response to an InterfaceTypeDefinition with the exact same fields
  3. Generate a diff using this tool
  4. An error is reported by the tool
    image

Expected behavior

No error should be reported if the change does not impact any queries made before the newest change.

Environment:

  • OS: Debian GNU/Linux
  • @graphql-inspector/...: 2.3.0
  • graphql: 1.3.72
  • NodeJS: v12.19.0
@gabsima-nexapp gabsima-nexapp changed the title ObjectTypeDefinition to InterfaceTypeDefinition creates error event if the fields are the same ObjectTypeDefinition to InterfaceTypeDefinition creates error even if the fields are the same Nov 12, 2020
@kamilkisiela kamilkisiela added the ⚙️ work in progress Someone is working on it label Dec 16, 2020
@theguild-bot theguild-bot mentioned this issue Apr 16, 2023
39 tasks
@theguild-bot theguild-bot mentioned this issue Oct 26, 2023
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ work in progress Someone is working on it
Projects
None yet
Development

No branches or pull requests

2 participants