Make .canvas property always present #2141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
adding a test for canvas propagation in group tests. |
|
@kangax this should be ready. |
kangax
added a commit
that referenced
this pull request
Apr 22, 2015
Make .canvas property always present
|
Perfect, thanks! Gotta add to change log. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i do not know if adding canvas to delegate properties, because this involves also reading.
anyway setting the canvas with ._set('canvas', value) automatically on object adding, both on canvas and on groups classes, should allow us to have canvas property spread to all objects inside ( in group and group of groups )