Remove old strokeWidth calculation #2155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kangax, after a bit of thinking i realized that strokeWidth = 1 and stroke = none is the good default. Is the same also in SVGs, so if we do not respect that all the svg import will fail or whe should change all the "fromElement" functions to add strokeWidth = 1 if not differently specified. The only place where i switched to strokeWidth = 0 is the group class. In this case stroke is not rendered and is useless to have it to 1 making the group width and height calculation unexpected ( one object with width 101 and group should have bounding rect 101 wide, not 101 + 1). I fixed the test with less changes possible, if you agree i do not have anything more to add you can pull. |
kangax
added a commit
that referenced
this pull request
May 3, 2015
Remove old strokeWidth calculation
|
@asturur please add to changelog |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to fix all the tests...
closes #1929