Fix image resize filter from object #2164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
couple of test needed |
|
|
||
| if (options.filters) { | ||
| this.filters = options.filters; | ||
| this.applyFilters(); |
There was a problem hiding this comment.
How would the filters be applied now during image initialization?
There was a problem hiding this comment.
Oh, I see your explanation. Sorry, got it!
|
After tests, I'm ready to merge then! |
|
@kangax any help on why the test is failing? it gives no clue. The row is: |
|
|
|
@kangax it is finally done. |
kangax
added a commit
that referenced
this pull request
May 5, 2015
Fix image resize filter from object
|
+Changelog |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note on changes on image initialize:
We are calling initElement, that calls setElement, that is calling initConfig and applyFilters.
So the part after this is just duplicated.