Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resubmit: Fix duplication of line styles when inserting a newline in IText #2193

Merged
merged 4 commits into from
May 13, 2015

Conversation

milan-w
Copy link
Contributor

@milan-w milan-w commented May 13, 2015

Resubmit as requested, merge conflicts resolved

When copying styles from oldStyles[lineIndex] to newStyles[lineIndex + 1] check if previous line was empty (and thus not iterated over) and if true, delete it.

There is a TODO comment in the function but I wasn't sure if that refers to this issue.
//TODO: evaluate if delete old style lines with offset -1

Closes #2188

kangax added a commit that referenced this pull request May 13, 2015
Resubmit: Fix duplication of line styles when inserting a newline in IText
@kangax kangax merged commit 07445de into fabricjs:master May 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IText] style duplication on inserting new line
2 participants