Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix style parsing #2256

Merged
merged 3 commits into from
Jun 3, 2015
Merged

Fix style parsing #2256

merged 3 commits into from
Jun 3, 2015

Conversation

asturur
Copy link
Member

@asturur asturur commented Jun 2, 2015

closes #2241

Changing regex should be fine instead of testing pair length.

@kangax
Copy link
Member

kangax commented Jun 2, 2015

Can we add a unit test?

@asturur
Copy link
Member Author

asturur commented Jun 2, 2015

@kangax done.

kangax added a commit that referenced this pull request Jun 3, 2015
@kangax
Merge pull request #2256 from asturur/fix-style-parsing
d817ae6 
Fix style parsing
@kangax kangax merged commit d817ae6 into fabricjs:master Jun 3, 2015
@asturur asturur deleted the fix-style-parsing branch June 8, 2015 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trim issue in parseStyleString while parseSVGdocument
2 participants
@asturur @kangax