Group opacity not delegated #2656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update to master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not a fan of delegate properties at all.
As mentioned in #2643 setting group opacity overrides all elements opacity.
Opacity is directly rendered in every object multiplying object opacity by group opacity, also overriding it would be wrong because setting half opacity for a group of object with mixed opacity levels would result in a flattened opacity for all.
Also if we delegate "fill" i do not see why we should not delegate "stroke" and "strokeWidth" that are not rendered in group, so if we are setting them we can set just on the objects.
closes #2643