Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cursor appear on not editable text. #2657

Merged
merged 2 commits into from
Nov 29, 2015
Merged

Fix cursor appear on not editable text. #2657

merged 2 commits into from
Nov 29, 2015

Conversation

asturur
Copy link
Member

@asturur asturur commented Nov 29, 2015

The main problem is that once the cursor starts to appear, the object is not on editing mode, so it won't exit from editing mode, so the cursor will never be stopped.

Cursor animatio is clearing the top canvas everytime making group selection not visible.

closes #2651

kangax added a commit that referenced this pull request Nov 29, 2015
Fix cursor appear on not editable text.
@kangax kangax merged commit 1053a91 into fabricjs:master Nov 29, 2015
@asturur asturur deleted the itextedita branch December 6, 2015 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Canvas selection color is gone when clicking the uneditable IText
2 participants