Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add active instance cleaning to dispose. #2708

Merged
merged 3 commits into from
Dec 27, 2015
Merged

Add active instance cleaning to dispose. #2708

merged 3 commits into from
Dec 27, 2015

Conversation

asturur
Copy link
Member

@asturur asturur commented Dec 24, 2015

closes #2701.

Still i do not get what this activeInstace does.
It is a reference to last initialized canvas.

But what is its purpouse?

@kangax
Copy link
Member

kangax commented Dec 24, 2015

Yep, last initialized one. Now that I think about it, it perhaps does seem unnecessary...

@asturur
Copy link
Member Author

asturur commented Dec 24, 2015

To me it looks unnecessary.
Maybe it was a try to do not create a global variable to access the canvas?

I would just trash it.

@kangax
Copy link
Member

kangax commented Dec 24, 2015

I agree. I'm all for removing unnecessary crap.

@asturur
Copy link
Member Author

asturur commented Dec 26, 2015

@kangax you can merge

kangax added a commit that referenced this pull request Dec 27, 2015
Add active instance cleaning to dispose.
@kangax kangax merged commit 8ffa6a1 into fabricjs:master Dec 27, 2015
@asturur asturur deleted the dispos branch January 3, 2016 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dispose should clear activeInstance
2 participants