Add active instance cleaning to dispose. #2708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep, last initialized one. Now that I think about it, it perhaps does seem unnecessary... |
|
To me it looks unnecessary. I would just trash it. |
|
I agree. I'm all for removing unnecessary crap. |
|
@kangax you can merge |
kangax
added a commit
that referenced
this pull request
Dec 27, 2015
Add active instance cleaning to dispose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2701.
Still i do not get what this activeInstace does.
It is a reference to last initialized canvas.
But what is its purpouse?