Change location of rect in 1x1 case #2817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As can be seen in this jsfiddle, https://jsfiddle.net/asteriskman/kk6v0tu4/ , the 1x1 rectangle was being placed incorrectly. It must be offset by -0.5 in the x and y direction to line up with other rects.
|
Could you please attach a screenshot of rect and spraybrush with and without the change? it looks good to me, just to be sure. |
|
Yes, I will make appropriate screenshots. |
|
Please review the screenshots here: http://imgur.com/a/Y7Ajg |
|
@kangax this is ok, i'm gonna merge it. |
asturur
added a commit
that referenced
this pull request
Mar 11, 2016
Change location of rect in 1x1 case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As can be seen in this jsfiddle, https://jsfiddle.net/asteriskman/kk6v0tu4/ , the optimized 1x1 rect was being placed incorrectly. It must be offset by -0.5 in the x and y direction to line up with other rects that are not subject to the 1x1 optimization.