Remove reference to lastRenderedWithControls when that object is deleted #3023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (obj === this.lastRenderedWithControls) { | ||
| delete this.lastRenderedWithControls; | ||
| } | ||
| this.callSuper('_onObjectRemoved', obj); |
There was a problem hiding this comment.
would it not fit in StaticCanvas more than Canvas? StaticCanvas does not have interactivity layer but still can render controls.
Other than that it look goods to me.
There was a problem hiding this comment.
this.lastRenderedWithControls is defined in the canvas.class.js. Should I move all uses of the flag to StaticCanvas?
There was a problem hiding this comment.
no you are right, it does not belong in StaticCanvas. is it fine like it is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where a user could remove a textbox from the canvas, and then click in the space where the textbox was, and it would re-appear.