Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hex Color RGBa #3202

Merged
merged 8 commits into from
Aug 26, 2016
Merged

Add Hex Color RGBa #3202

merged 8 commits into from
Aug 26, 2016

Conversation

neopheus
Copy link
Contributor

@neopheus neopheus commented Aug 25, 2016

Add RGBa (8 digits, #FF5544CC)
https://drafts.csswg.org/css-color/#hex-notation

closes #1727

@asturur
Copy link
Member

asturur commented Aug 25, 2016

looks nice to me.
Could you please check which is the status of css3 about this color notation?

@neopheus
Copy link
Contributor Author

For W3C/CSS : https://www.w3.org/TR/css-color-4/#hex-notation
And, for Mozilla : https://developer.mozilla.org/en-US/docs/Web/CSS/color_value#rgba()

No more info about css3 and this color notation

@asturur
Copy link
Member

asturur commented Aug 25, 2016

Would you be so kind to add also the 4 digit notation? so we are complete.
I think we should pull it in.

@neopheus
Copy link
Contributor Author

no pb ;)

@asturur
Copy link
Member

asturur commented Aug 26, 2016

thanks, nice PR.

@asturur asturur merged commit a6bc04c into fabricjs:master Aug 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no RGBA
2 participants