Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed selection, added test #3254

Merged
merged 1 commit into from
Sep 11, 2016
Merged

fixed selection, added test #3254

merged 1 commit into from
Sep 11, 2016

Conversation

asturur
Copy link
Member

@asturur asturur commented Sep 11, 2016

I change again the logic of selection. I hope this time everyone find it feasible.

  1. clicked activegroup? return activeGroup
  2. clicked activeObject on a corner? return activeObject
  3. clicked activeObject and preserveObjectStacking is false? return activeObject.
    clicked activeObject? ok take note. Examine targets.....
  4. target is activeObject again? return activeObject.
  5. target is an object that is over activeObject? check if the alternativeSelectionKey is pressed.
    key is pressed? if yes return activeObject, normally return the target clicked.

So there is a solution for selecting activeObjects under another object but that require a keypress ( configurable ). In normal situation the topmost object is returned.

close #3095

@asturur
Copy link
Member Author

asturur commented Sep 11, 2016

@neopheus

@asturur asturur merged commit c34027c into master Sep 11, 2016
@asturur asturur deleted the fixoverlappingobjects branch September 11, 2016 19:34
asturur added a commit that referenced this pull request Sep 15, 2016
* fixed selection, added test (#3254)

* Update stateful.mixin.js

* better save state check

* made clone deep and savestate deep

* fixes

* fixes

* swapped check source
asturur added a commit that referenced this pull request Sep 17, 2016
* fixed selection, added test (#3254)

* allow for deep state check and save (#3262)

* added fill for images

* added fill for images

* added fill for images

* fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make small object on top of active one selectable with preserve object stacking true
1 participant