Remove some code from ITEXT, do not pollute styles if not necessary #3743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asturur
commented
Feb 25, 2017
| leftOffset = (lineIndex === 0 && charIndex === 0) | ||
| ? this._getLineLeftOffset(this._getLineWidth(this.ctx, lineIndex)) | ||
| : boundaries.leftOffset, | ||
| leftOffset = boundaries.leftOffset, |
There was a problem hiding this comment.
boundaries.leftOffset and this._getLineLeftOffset(this._getLineWidth(this.ctx, lineIndex)) carry the same value. no need to make a special case.
asturur
commented
Feb 25, 2017
| if (!this.styles[lineIndex + 1]) { | ||
| this.styles[lineIndex + 1] = {}; | ||
| } | ||
|
|
There was a problem hiding this comment.
no need to create an empty style object for a line just because maybe we will put something into it.
asturur
commented
Feb 25, 2017
| // remove lines from the previous line since they're on a new line now | ||
| delete this.styles[lineIndex][index]; | ||
| } | ||
| } | ||
| this.styles[lineIndex + 1] = newLineStyles; | ||
| somethingAdded && (this.styles[lineIndex + 1] = newLineStyles); |
There was a problem hiding this comment.
create the new line style only if necessary
asturur
commented
Feb 25, 2017
| } | ||
| } | ||
| //TODO: evaluate if delete old style lines with offset -1 | ||
| fabric.IText.prototype.shiftLineStyles.call(this, lineIndex, offset); |
There was a problem hiding this comment.
the prototype function does exactly the same thing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.