Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force async #3996

Merged
merged 4 commits into from
Jun 11, 2017
Merged

Force async #3996

merged 4 commits into from
Jun 11, 2017

Conversation

asturur
Copy link
Member

@asturur asturur commented Jun 11, 2017

Remove the force async logic from fromObject.
All fromObject and clone work in async way.

@asturur asturur merged commit 145bd3b into master Jun 11, 2017
@asturur asturur deleted the forceAsync branch June 11, 2017 19:37
@sfentress
Copy link

Hi @asturur , I've been updating an old project from 1.x to the current version, and the dropping of object.async was never mentioned in any change logs or notes that I could find. It took me a long time to track this change down.

It might have been worth keeping async = true, since all code now acts as it did when async existed and was true. All my code along the lines the following broke.

if (klass.async) {
      activeObject.clone(function (clonedObject) {
        clone = clonedObject;
      }
    } else {
      var clone = activeObject.clone();
    }

But I guess three years on this is a moot point.

@asturur
Copy link
Member Author

asturur commented Jul 3, 2020

When i got to update fabric from 1 to 2 i had still lot to learn around backward compatibility and possible breakage patterns. Not that now i m a genius, but 3 years ago was far worse.

@sfentress
Copy link

No problem! And my message above was not particularly helpful either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants