Update rgba regex to account for alpha #4006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous regex would fail for an rgba string with a non integer alpha value. "rgba(255, 128, 64, .5)"
|
in this file add a test like the one i underlined that parse a color with opacity .x instead of 0.x and verify that the value is read correctly. And we are done |
|
managed to do it |
|
Thanks. I was trying to follow your instructions (I haven't contributed to a github project before) and when I followed the URL you gave me it told me I couldn't make changes unless I was in a branch. I made the change in my branch but couldn't figure out how to commit it so it would be added to the pull request. Thanks again for the help. |
asturur
pushed a commit
that referenced
this pull request
Jun 14, 2017
* Update rgba regex to account for alpha Previous regex would fail for an rgba string with a non integer alpha value. "rgba(255, 128, 64, .5)" * Create color.js * Create color.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous regex would fail for an rgba string with a non integer alpha value. "rgba(255, 128, 64, .5)"
closes #4004