Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinsert text shortcut for some cases #4519

Merged
merged 3 commits into from
Dec 2, 2017
Merged

Reinsert text shortcut for some cases #4519

merged 3 commits into from
Dec 2, 2017

Conversation

asturur
Copy link
Member

@asturur asturur commented Nov 30, 2017

Add a faster rendering in case we do not have nor style nor alignement for a particular line

close #4514

Copy link
Contributor

@JSteunou JSteunou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line.join('') then it's a good to go for me :)

@asturur
Copy link
Member Author

asturur commented Dec 2, 2017

we can skip the join since we have already the text ready in another array

@asturur asturur merged commit c96bb92 into master Dec 2, 2017
@asturur asturur deleted the shortcut branch January 1, 2018 22:55
thiagocunha pushed a commit to thiagocunha/fabric.js that referenced this pull request Nov 18, 2019
* test

* use simple text line not grapheme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

V2 is slower at rendering simple text
2 participants