Add patternTransform toObject saving #4626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asturur
reviewed
Jan 17, 2018
src/pattern.class.js
Outdated
| @@ -95,6 +95,7 @@ | |||
| repeat: this.repeat, | |||
| offsetX: toFixed(this.offsetX, NUM_FRACTION_DIGITS), | |||
| offsetY: toFixed(this.offsetY, NUM_FRACTION_DIGITS), | |||
| patternTransform: this.patternTransform | |||
There was a problem hiding this comment.
patternTransform: this. patternTransform ? this. patternTransform.concat() : null
this allow to avoid sending out a reference to the real matrix that could be changed by other function later.
A sort of shallow protection on mutations.
You do not expect your object to to influence rendering once exported.
There was a problem hiding this comment.
great version ( at this version you broke video scalling ;))
|
@DangerD256 do you think you can make this correction? |
asturur
requested changes
Jan 17, 2018
asturur
approved these changes
Jan 17, 2018
asturur
approved these changes
Jan 17, 2018
thiagocunha
pushed a commit
to thiagocunha/fabric.js
that referenced
this pull request
Nov 18, 2019
* Add patternTransform toObject saving * Update pattern.class.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4625