-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add drawDot func to pencilbrush #4743
Conversation
…uitable for low-profile phone.
Ok so this is what i meant.
In this way i achieved exactly your goal, but in addition i minimized code changes. It make easeir to see what changed. |
cool ! so beautiful code you do. |
Do not worry is just practice. In this way the capture logic is unchanged, and we should not be worried. The drawing logic still needs to be tested manually but it looks good to me. Please confirm me that it draws as intended and that performances are improved on slow phones, and i ll merge it. |
@boomyao, does it works good? |
@asturur, maybe this PR should be close. |
no i think we can fix it. let's try |
i think we are good with this latest change. |
@asturur Great ! ! Thank you for give me a lesson! |
This reverts commit f855bbc.
add simplePencil_brush that _render not needs to redraw everything, suitable for low-profile phone.
close #4680