New PR fo 4808 #4831
Merged
New PR fo 4808 #4831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asturur
reviewed
Mar 16, 2018
src/shapes/text.class.js
Outdated
| @@ -1203,12 +1203,16 @@ | |||
| */ | |||
| _getFontDeclaration: function(styleObject, forMeasuring) { | |||
| var style = styleObject || this; | |||
| var fontFamily = style.fontFamily === undefined || | |||
| style.fontFamily.includes('\'') || | |||
| style.fontFamily.includes('"') | |||
There was a problem hiding this comment.
sorry to be late with this comment.
includes is something forever supported by IE, just recently included in firefox and chrome as per new specs.
I think there is a string method that is supported by everyone and should be es5 compatible.
FabricJS is es5 and .includes is not.
|
@asturur Right, we use an ES6 polyfill in webpack, so I didn't notice. I changed the code to use indexOf instead of includes. |
|
Thank you! |
Merged
thiagocunha
pushed a commit
to thiagocunha/fabric.js
that referenced
this pull request
Nov 18, 2019
* new commit per asturur * new commit per asturur
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4808