Fix getPointer on touch devices #4866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asturur
reviewed
Mar 29, 2018
src/util/dom_event.js
Outdated
| pointer = event[touchProp][0][pageProp] - (event[touchProp][0][pageProp] - event[touchProp][0][clientProp]); | ||
| } | ||
|
|
||
| if (!pointer && pointer !== 0) { |
There was a problem hiding this comment.
isn't this better as typeof pointer === 'undefined' ? that is the real meaning of it, if yuo did manage to assign anything to pointer in the first if, right?
There was a problem hiding this comment.
yea it should work the same. I'll change it.
If the pointer is at x=0 or y=0, it returns NaN.
|
i just noticed that pageProp - ( pageProp - clientProp) is just equal to +clientProp |
Merged
thiagocunha
pushed a commit
to thiagocunha/fabric.js
that referenced
this pull request
Nov 18, 2019
* Fix getPointer on touch devices If the pointer is at x=0 or y=0, it returns NaN. * Update dom_event.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dragging an object on touch device on top or left edge of a screen, the getPointer function returns an incorrect value (NaN).
To reproduce it, you can use the following demo : http://fabricjs.com/intersection and move an object to the left side.
When clientX and pageX are 0, the internal _getPointer method returns event[clientProp] which is undefined instead of 0.