Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

selectionDashArray causing issues when free drawing #4894

Closed
arlen-yu opened this issue Apr 9, 2018 · 0 comments · Fixed by #4897
Closed

selectionDashArray causing issues when free drawing #4894

arlen-yu opened this issue Apr 9, 2018 · 0 comments · Fixed by #4897

Comments

@arlen-yu
Copy link
Contributor

arlen-yu commented Apr 9, 2018

Version

2.2.3

Test Case

http://jsfiddle.net/Da7SP/1459/

Steps to reproduce

  1. initialize canvas with selectionDashArray
  2. click and drag to show that selectionDashArray exists
  3. set canvas isDrawingMode to true
  4. free draw on the canvas

Expected Behavior

While drawing, the line should appear solid

Actual Behavior

While drawing, the line appears as dashed, but on mouseUp returns to a solid line
@arlen-yu arlen-yu mentioned this issue Apr 10, 2018
Merged
asturur pushed a commit that referenced this issue Apr 11, 2018
@arlen-yu @asturur
Fixing issues with selectionDashArray bleeding into free drawing (#4894…
d73dbab 
…) (#4897)

* Fixing issues with selectionDashArray bleeding into free drawing

* Resetting line dash in _setBrushStyles when there is no strokeDashArray
@asturur asturur mentioned this issue May 8, 2018
Merged
thiagocunha pushed a commit to thiagocunha/fabric.js that referenced this issue Nov 18, 2019
@arlen-yu @asturur
Fixing issues with selectionDashArray bleeding into free drawing (fab…
f59a523 
…ricjs#4894) (fabricjs#4897)

* Fixing issues with selectionDashArray bleeding into free drawing

* Resetting line dash in _setBrushStyles when there is no strokeDashArray
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing issues with selectionDashArray bleeding into free drawing (#4894) arlen-yu/fabric.js
1 participant
@arlen-yu