-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No events fired after resize with pinch zoom. #510
Comments
Looks like we fire "touch:gesture" event but not the others. |
Actually, there's "touchend" listener which should call "__onMouseUp" and fire "object:modified" accordingly (unless something else goes wrong). |
After further testing it's object:scaling that doesn't fire. I am using that to make sure that a rectangle cannot be expanded outside the canvas. This page is the one that gets bounded when not using pinch zoom on a touch device: |
Is this still happening? |
In the version of fabric.js I'm using in this page (1.2.1), on an iPad, pinch will scale the object but will not fire object:scaling: http://memecaptain.com/gend_images/new?src=_k6JVg In this jsfiddle with 1.4.0, on an iPad, pinch will not scale the object. Also object:scaling never fires, even on non-touch screens. A canvas with a background image seems to prevent the object:scaling callback. |
@mmb what about latest 1.4.9? |
1.4.9 behaves like 1.4.0. Pinch zoom does not scale on an iPad. Corner scaling does not fire |
Hey @kangax, here's a fix for this issue. I noticed this too. The gestures code wasn't firing |
Hey @jafferhaider, thanks! Any chance you could send a PR? That would be amazing. |
After resizing an object using pinch zoom on a touch device, no events are fired. Should object.modified be fired after gestureend?
The text was updated successfully, but these errors were encountered: