-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--set-<value>
should have a --value
counter part for session based options
#36
Comments
@nopeless flags would be one way of doing that, however you can already use the environment variables. Every configuration option has an associated environment variable, eg:
or
|
@kardolus environment variables are hard to keep in closures especially in powershell they don't have something like |
@nopeless ahh gotcha. I didn't know that about powershell. I can add the |
btw by --value i was thinking about --max-tokens for example. i hope it isn't that confusing e.g. chatgpt-cli --role "You are developer" -i |
I am finally ready to pick this one up. I am reinventing a lot of the Viper functionality in my CLI. I want to get rid of my own logic as much as I can and fall back to Viper. Will work on this issue in parallel to this one: #68 I think both can be solved within the same refactor. |
FYI, started working on it here: https://github.com/kardolus/chatgpt-cli/tree/viper-refactor It's a massive refactor. It's not done yet (I want setters for all values). Here's a preview though:
|
Yikes, it's pretty cluttered haha. Getting there though.
|
Fixed in this commit: 1ad9eeb Release: https://github.com/kardolus/chatgpt-cli/releases/tag/v1.7.0 |
@kardolus I'm reading your second most recent comment, and it appears that the casing for the commands seem inconsistent? I don't think that's a good idea. Id like to hear your reasoning |
Your right! That’s fixed :) |
Here's the new output:
|
@nopeless unless you mean something else. I figured the snake vs kebab case was what you meant. Am I overlooking upper/lower casing? |
@kardolus I was referring to the mixed kebab and snake case. Thanks for fixing it 👍 |
--set-<value>
writes to file. I wouldn't want that.The text was updated successfully, but these errors were encountered: